diff options
| author | Nico Huber <nico.h@gmx.de> | 2018-12-23 20:03:35 +0100 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2019-07-31 08:26:59 +0000 |
| commit | 519be66fc59558971dd653afe69ccaf1a633b492 (patch) | |
| tree | 74f0912de156a86d56111f377db080246e5205e9 /it87spi.c | |
| parent | ef78de4a21323b8c459337356289218211f2c5ce (diff) | |
| download | flashrom-519be66fc59558971dd653afe69ccaf1a633b492.tar.gz flashrom-519be66fc59558971dd653afe69ccaf1a633b492.tar.bz2 flashrom-519be66fc59558971dd653afe69ccaf1a633b492.zip | |
Fix -Wsign-compare trouble
Mostly by changing to `unsigned` types where applicable, sometimes
`signed` types, and casting as a last resort.
Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/30409
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jacob Garber <jgarber1@ualberta.ca>
Diffstat (limited to 'it87spi.c')
| -rw-r--r-- | it87spi.c | 3 |
1 files changed, 2 insertions, 1 deletions
@@ -281,7 +281,6 @@ static int it8716f_spi_send_command(struct flashctx *flash, unsigned char *readarr) { uint8_t busy, writeenc; - int i; do { busy = INB(it8716f_flashport) & 0x80; @@ -330,6 +329,8 @@ static int it8716f_spi_send_command(struct flashctx *flash, | ((readcnt & 0x3) << 2) | (writeenc), it8716f_flashport); if (readcnt > 0) { + unsigned int i; + do { busy = INB(it8716f_flashport) & 0x80; } while (busy); |