diff options
| author | Edward O'Callaghan <quasisec@google.com> | 2020-10-09 13:00:17 +1100 |
|---|---|---|
| committer | Edward O'Callaghan <quasisec@chromium.org> | 2020-10-12 04:42:53 +0000 |
| commit | d4d3657b4d64b8fa38eb05ab2a50fdea3e1b45a4 (patch) | |
| tree | 5cac34abfff754e98194838e68434630376604a6 /it87spi.c | |
| parent | 91c10aebb35893fdabb2d094155745468b90b5f5 (diff) | |
| download | flashrom-d4d3657b4d64b8fa38eb05ab2a50fdea3e1b45a4.tar.gz flashrom-d4d3657b4d64b8fa38eb05ab2a50fdea3e1b45a4.tar.bz2 flashrom-d4d3657b4d64b8fa38eb05ab2a50fdea3e1b45a4.zip | |
it87spi.c: Fix layering violation of default_spi_read
default_spi_read() calls spi_read_chunked() with the correct
max_read value of 3 set in the spi master struct.
Change-Id: I199c81e1ba501e86dbfb7cf18e2d1556e30db62e
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/46233
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Sam McNally <sammc@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'it87spi.c')
| -rw-r--r-- | it87spi.c | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -108,7 +108,7 @@ static int it8716f_spi_chip_write_256(struct flashctx *flash, const uint8_t *buf unsigned int start, unsigned int len); static const struct spi_master spi_master_it87xx = { - .max_data_read = MAX_DATA_UNSPECIFIED, + .max_data_read = 3, .max_data_write = MAX_DATA_UNSPECIFIED, .command = it8716f_spi_send_command, .multicommand = default_spi_send_multicommand, @@ -380,7 +380,7 @@ static int it8716f_spi_chip_read(struct flashctx *flash, uint8_t *buf, * via a programmer parameter for the internal programmer. */ if ((flash->chip->total_size * 1024 > 512 * 1024)) { - spi_read_chunked(flash, buf, start, len, 3); + default_spi_read(flash, buf, start, len); } else { mmio_readn((void *)(flash->virtual_memory + start), buf, len); } |