summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJiawen Wu <jiawenwu@trustnetic.com>2024-09-24 10:28:57 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2024-10-10 12:01:05 +0200
commit01feafd82a6878901e66494c6710635c4a0e81e0 (patch)
tree610e82d2293b417897c8beddbbafe75892ee02a0
parent765f033f26a9c97ffb2c7ee00b7d846ea26042c1 (diff)
downloadlinux-stable-01feafd82a6878901e66494c6710635c4a0e81e0.tar.gz
linux-stable-01feafd82a6878901e66494c6710635c4a0e81e0.tar.bz2
linux-stable-01feafd82a6878901e66494c6710635c4a0e81e0.zip
net: pcs: xpcs: fix the wrong register that was written back
commit 93ef6ee5c20e9330477930ec6347672c9e0cf5a6 upstream. The value is read from the register TXGBE_RX_GEN_CTL3, and it should be written back to TXGBE_RX_GEN_CTL3 when it changes some fields. Cc: stable@vger.kernel.org Fixes: f629acc6f210 ("net: pcs: xpcs: support to switch mode for Wangxun NICs") Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com> Reported-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Link: https://patch.msgid.link/20240924022857.865422-1-jiawenwu@trustnetic.com Signed-off-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/net/pcs/pcs-xpcs-wx.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/pcs/pcs-xpcs-wx.c b/drivers/net/pcs/pcs-xpcs-wx.c
index 19c75886f070..5f5cd3596cb8 100644
--- a/drivers/net/pcs/pcs-xpcs-wx.c
+++ b/drivers/net/pcs/pcs-xpcs-wx.c
@@ -109,7 +109,7 @@ static void txgbe_pma_config_1g(struct dw_xpcs *xpcs)
txgbe_write_pma(xpcs, TXGBE_DFE_TAP_CTL0, 0);
val = txgbe_read_pma(xpcs, TXGBE_RX_GEN_CTL3);
val = u16_replace_bits(val, 0x4, TXGBE_RX_GEN_CTL3_LOS_TRSHLD0);
- txgbe_write_pma(xpcs, TXGBE_RX_EQ_ATTN_CTL, val);
+ txgbe_write_pma(xpcs, TXGBE_RX_GEN_CTL3, val);
txgbe_write_pma(xpcs, TXGBE_MPLLA_CTL0, 0x20);
txgbe_write_pma(xpcs, TXGBE_MPLLA_CTL3, 0x46);