diff options
| author | Ido Schimmel <idosch@mellanox.com> | 2018-03-19 09:51:03 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-03-20 12:11:02 -0400 |
| commit | 04719507b756e5eb38282c33162a9c89beb6f440 (patch) | |
| tree | 2f901464678adac36e347da9dbce5dfb3b9dd766 | |
| parent | 808be37ae323ed5585a3e6257ccb5b435bd1a4b9 (diff) | |
| download | linux-stable-04719507b756e5eb38282c33162a9c89beb6f440.tar.gz linux-stable-04719507b756e5eb38282c33162a9c89beb6f440.tar.bz2 linux-stable-04719507b756e5eb38282c33162a9c89beb6f440.zip | |
mlxsw: spectrum_acl: Do not invalidate already invalid ACL groups
When a new ACL group is created its region (ACL) list is initially
empty. Thus, the call to mlxsw_sp_acl_tcam_group_update() would
basically invalidate an already invalid (non-existent) group.
Remove the unnecessary call and make the function symmetric to its del()
counterpart.
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c index c6e180c2be1e..ad1b548e3cac 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c @@ -228,10 +228,6 @@ mlxsw_sp_acl_tcam_group_add(struct mlxsw_sp *mlxsw_sp, if (err) return err; - err = mlxsw_sp_acl_tcam_group_update(mlxsw_sp, group); - if (err) - goto err_group_update; - err = rhashtable_init(&group->chunk_ht, &mlxsw_sp_acl_tcam_chunk_ht_params); if (err) @@ -240,7 +236,6 @@ mlxsw_sp_acl_tcam_group_add(struct mlxsw_sp *mlxsw_sp, return 0; err_rhashtable_init: -err_group_update: mlxsw_sp_acl_tcam_group_id_put(tcam, group->id); return err; } |