diff options
| author | Aaron Armstrong Skomra <skomra@gmail.com> | 2017-08-28 14:15:39 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-10-12 11:51:24 +0200 |
| commit | 04b54e8ff7d01b6e877f9a7915bc30be67dd5c39 (patch) | |
| tree | 4483042e398d70756c4ccbade2cfe700dbb3174e | |
| parent | 5abb9cd4ff92c03410679842ba0cf9be4162873b (diff) | |
| download | linux-stable-04b54e8ff7d01b6e877f9a7915bc30be67dd5c39.tar.gz linux-stable-04b54e8ff7d01b6e877f9a7915bc30be67dd5c39.tar.bz2 linux-stable-04b54e8ff7d01b6e877f9a7915bc30be67dd5c39.zip | |
HID: wacom: leds: Don't try to control the EKR's read-only LEDs
commit 74aebed6dc13425233f2224668353cff7a112776 upstream.
Commit a50aac7193f1 introduces 'led.groups' and adds EKR support
for these groups. However, unlike the other devices with LEDs,
the EKR's LEDs are read-only and we shouldn't attempt to control
them in wacom_led_control().
See bug: https://sourceforge.net/p/linuxwacom/bugs/342/
Fixes: a50aac7193f1 ("HID: wacom: leds: dynamically allocate LED groups")
Signed-off-by: Aaron Armstrong Skomra <aaron.skomra@wacom.com>
Reviewed-by: Jason Gerecke <jason.gerecke@wacom.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/hid/wacom_sys.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index 53ac19b3727a..0224df2991af 100644 --- a/drivers/hid/wacom_sys.c +++ b/drivers/hid/wacom_sys.c @@ -712,6 +712,9 @@ static int wacom_led_control(struct wacom *wacom) if (!wacom->led.groups) return -ENOTSUPP; + if (wacom->wacom_wac.features.type == REMOTE) + return -ENOTSUPP; + if (wacom->wacom_wac.pid) { /* wireless connected */ report_id = WAC_CMD_WL_LED_CONTROL; buf_size = 13; |