diff options
| author | Waiman Long <longman@redhat.com> | 2024-04-23 21:00:20 -0400 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2024-04-23 17:31:18 -1000 |
| commit | 04d63da4da53e6064683f4970d34ce997f9daee3 (patch) | |
| tree | dff497d03e8e739fb9a00a7a139c0b0ef2b6560d | |
| parent | e8784765fae6edc47efb68d425c65e3633d70cd6 (diff) | |
| download | linux-stable-04d63da4da53e6064683f4970d34ce997f9daee3.tar.gz linux-stable-04d63da4da53e6064683f4970d34ce997f9daee3.tar.bz2 linux-stable-04d63da4da53e6064683f4970d34ce997f9daee3.zip | |
cgroup/cpuset: Fix incorrect top_cpuset flags
Commit 8996f93fc388 ("cgroup/cpuset: Statically initialize more
members of top_cpuset") uses an incorrect "<" relational operator for
the CS_SCHED_LOAD_BALANCE bit when initializing the top_cpuset. This
results in load_balancing turned off by default in the top cpuset which
is bad for performance.
Fix this by using the BIT() helper macro to set the desired top_cpuset
flags and avoid similar mistake from being made in the future.
Fixes: 8996f93fc388 ("cgroup/cpuset: Statically initialize more members of top_cpuset")
Signed-off-by: Waiman Long <longman@redhat.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
| -rw-r--r-- | kernel/cgroup/cpuset.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index 032fcc93f2b8..f5443c039619 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -368,8 +368,8 @@ static inline void notify_partition_change(struct cpuset *cs, int old_prs) } static struct cpuset top_cpuset = { - .flags = ((1 << CS_ONLINE) | (1 << CS_CPU_EXCLUSIVE) | - (1 << CS_MEM_EXCLUSIVE) | (1 < CS_SCHED_LOAD_BALANCE)), + .flags = BIT(CS_ONLINE) | BIT(CS_CPU_EXCLUSIVE) | + BIT(CS_MEM_EXCLUSIVE) | BIT(CS_SCHED_LOAD_BALANCE), .partition_root_state = PRS_ROOT, .relax_domain_level = -1, .remote_sibling = LIST_HEAD_INIT(top_cpuset.remote_sibling), |