summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2022-03-24 08:52:07 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-04-08 13:58:35 +0200
commit05f90fe2c7e8f27d7691ae57cb604e4c156b70e6 (patch)
tree059e3daa80871ca55c94a7e8895f52721b47a810
parent11f03ba4bcaba6d3a26e109ab7bd5a2b2a53bd93 (diff)
downloadlinux-stable-05f90fe2c7e8f27d7691ae57cb604e4c156b70e6.tar.gz
linux-stable-05f90fe2c7e8f27d7691ae57cb604e4c156b70e6.tar.bz2
linux-stable-05f90fe2c7e8f27d7691ae57cb604e4c156b70e6.zip
lib/test: use after free in register_test_dev_kmod()
[ Upstream commit dc0ce6cc4b133f5f2beb8b47dacae13a7d283c2c ] The "test_dev" pointer is freed but then returned to the caller. Fixes: d9c6a72d6fa2 ("kmod: add test driver to stress test the module loader") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--lib/test_kmod.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/lib/test_kmod.c b/lib/test_kmod.c
index ce1589391413..cb800b1d0d99 100644
--- a/lib/test_kmod.c
+++ b/lib/test_kmod.c
@@ -1149,6 +1149,7 @@ static struct kmod_test_device *register_test_dev_kmod(void)
if (ret) {
pr_err("could not register misc device: %d\n", ret);
free_test_dev_kmod(test_dev);
+ test_dev = NULL;
goto out;
}