diff options
| author | Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> | 2023-05-08 23:07:16 -0700 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2023-05-17 12:15:09 +0530 |
| commit | 0642287e3ecdd0d1f88e6a2e63768e16153a990c (patch) | |
| tree | da1cd6573a517426c5ee5a4ff80a1d146970ecda | |
| parent | ac9a78681b921877518763ba0e89202254349d1b (diff) | |
| download | linux-stable-0642287e3ecdd0d1f88e6a2e63768e16153a990c.tar.gz linux-stable-0642287e3ecdd0d1f88e6a2e63768e16153a990c.tar.bz2 linux-stable-0642287e3ecdd0d1f88e6a2e63768e16153a990c.zip | |
dmaengine: idxd: Fix passing freed memory in idxd_cdev_open()
Smatch warns:
drivers/dma/idxd/cdev.c:327:
idxd_cdev_open() warn: 'sva' was already freed.
When idxd_wq_set_pasid() fails, the current code unbinds sva and then
goes to 'failed_set_pasid' where iommu_sva_unbind_device is called
again causing the above warning.
[ device_user_pasid_enabled(idxd) is still true when calling
failed_set_pasid ]
Fix this by removing additional unbind when idxd_wq_set_pasid() fails
Fixes: b022f59725f0 ("dmaengine: idxd: add idxd_copy_cr() to copy user completion record during page fault handling")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Acked-by: Fenghua Yu <fenghua.yu@intel.com>
Acked-by: Dave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/20230509060716.2830630-1-harshit.m.mogalapalli@oracle.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
| -rw-r--r-- | drivers/dma/idxd/cdev.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/dma/idxd/cdev.c b/drivers/dma/idxd/cdev.c index ecbf67c2ad2b..d32deb9b4e3d 100644 --- a/drivers/dma/idxd/cdev.c +++ b/drivers/dma/idxd/cdev.c @@ -277,7 +277,6 @@ static int idxd_cdev_open(struct inode *inode, struct file *filp) if (wq_dedicated(wq)) { rc = idxd_wq_set_pasid(wq, pasid); if (rc < 0) { - iommu_sva_unbind_device(sva); dev_err(dev, "wq set pasid failed: %d\n", rc); goto failed_set_pasid; } |