diff options
| author | yangerkun <yangerkun@huawei.com> | 2020-02-26 11:54:35 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-03-20 10:54:25 +0100 |
| commit | 085e871e8037849e9c574d86a79aa7b51ee5c952 (patch) | |
| tree | 801db06b548e2b2b42fa1480512cfd05823ca4da | |
| parent | d8a4a55bdcf50206de12766400c989de2f840d1a (diff) | |
| download | linux-stable-085e871e8037849e9c574d86a79aa7b51ee5c952.tar.gz linux-stable-085e871e8037849e9c574d86a79aa7b51ee5c952.tar.bz2 linux-stable-085e871e8037849e9c574d86a79aa7b51ee5c952.zip | |
slip: not call free_netdev before rtnl_unlock in slip_open
[ Upstream commit f596c87005f7b1baeb7d62d9a9e25d68c3dfae10 ]
As the description before netdev_run_todo, we cannot call free_netdev
before rtnl_unlock, fix it by reorder the code.
Signed-off-by: yangerkun <yangerkun@huawei.com>
Reviewed-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/net/slip/slip.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/net/slip/slip.c b/drivers/net/slip/slip.c index b07f367abd91..d7882b548b79 100644 --- a/drivers/net/slip/slip.c +++ b/drivers/net/slip/slip.c @@ -867,7 +867,10 @@ err_free_chan: tty->disc_data = NULL; clear_bit(SLF_INUSE, &sl->flags); sl_free_netdev(sl->dev); + /* do not call free_netdev before rtnl_unlock */ + rtnl_unlock(); free_netdev(sl->dev); + return err; err_exit: rtnl_unlock(); |