diff options
| author | Julia Lawall <julia@diku.dk> | 2010-01-21 02:43:20 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-01-21 02:43:20 -0800 |
| commit | 09cb47a2c68f9596927bc05dab0453edb35cd32d (patch) | |
| tree | 5aad2a10a6ea10d8a80cfffabc63cae42871376a | |
| parent | 17660f81243e998f36257881ac3ae61685bf91c1 (diff) | |
| download | linux-stable-09cb47a2c68f9596927bc05dab0453edb35cd32d.tar.gz linux-stable-09cb47a2c68f9596927bc05dab0453edb35cd32d.tar.bz2 linux-stable-09cb47a2c68f9596927bc05dab0453edb35cd32d.zip | |
net/sctp: Eliminate useless code
The variable newinet is initialized twice to the same (side effect-free)
expression. Drop one initialization.
A simplified version of the semantic match that finds this problem is:
(http://coccinelle.lip6.fr/)
// <smpl>
@forall@
idexpression *x;
identifier f!=ERR_PTR;
@@
x = f(...)
... when != x
(
x = f(...,<+...x...+>,...)
|
* x = f(...)
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/sctp/socket.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sctp/socket.c b/net/sctp/socket.c index 67fdac9d2d33..f6d1e59c4151 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -6359,7 +6359,7 @@ void sctp_copy_sock(struct sock *newsk, struct sock *sk, struct sctp_association *asoc) { struct inet_sock *inet = inet_sk(sk); - struct inet_sock *newinet = inet_sk(newsk); + struct inet_sock *newinet; newsk->sk_type = sk->sk_type; newsk->sk_bound_dev_if = sk->sk_bound_dev_if; |