diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2017-08-01 17:20:39 +0200 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> | 2017-08-01 17:20:39 +0200 |
commit | 0ae6ee006cec19d9f53f3d042de173f4b70649df (patch) | |
tree | 59547677076960e5dafe788879e0e78f4320c4e7 | |
parent | a86d8d67989d1b89ff396be2c0f7f8be2524d38a (diff) | |
download | linux-stable-0ae6ee006cec19d9f53f3d042de173f4b70649df.tar.gz linux-stable-0ae6ee006cec19d9f53f3d042de173f4b70649df.tar.bz2 linux-stable-0ae6ee006cec19d9f53f3d042de173f4b70649df.zip |
fbdev: da8xx-fb: Drop unnecessary static
Drop static on a local variable, when the variable is initialized before
any possible use. Thus, the static has no benefit.
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@bad exists@
position p;
identifier x;
type T;
@@
static T x@p;
...
x = <+...x...+>
@@
identifier x;
expression e;
type T;
position p != bad.p;
@@
-static
T x@p;
... when != x
when strict
?x = e;
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
-rw-r--r-- | drivers/video/fbdev/da8xx-fb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/video/fbdev/da8xx-fb.c b/drivers/video/fbdev/da8xx-fb.c index c229b1a0d13b..a74096c53cb5 100644 --- a/drivers/video/fbdev/da8xx-fb.c +++ b/drivers/video/fbdev/da8xx-fb.c @@ -1341,7 +1341,7 @@ static int fb_probe(struct platform_device *device) { struct da8xx_lcdc_platform_data *fb_pdata = dev_get_platdata(&device->dev); - static struct resource *lcdc_regs; + struct resource *lcdc_regs; struct lcd_ctrl_config *lcd_cfg; struct fb_videomode *lcdc_info; struct fb_info *da8xx_fb_info; |