diff options
| author | Michal Wilczynski <michal.wilczynski@intel.com> | 2023-07-03 11:02:45 +0300 |
|---|---|---|
| committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2023-07-14 18:58:34 +0200 |
| commit | 0d16710146a10cf62b3efddee8ffd006432d5d7e (patch) | |
| tree | 8e52a5609ffbe51629a31c7f2b7c450e14019054 | |
| parent | c542ce36a9f0bbf7c3a607ee31f1c39fda280782 (diff) | |
| download | linux-stable-0d16710146a10cf62b3efddee8ffd006432d5d7e.tar.gz linux-stable-0d16710146a10cf62b3efddee8ffd006432d5d7e.tar.bz2 linux-stable-0d16710146a10cf62b3efddee8ffd006432d5d7e.zip | |
ACPI: bus: Set driver_data to NULL every time .add() fails
Most ACPI drivers set driver_data in their .add() callbacks, but usually
they don't clear it in the error code path.
Set driver_data to NULL in acpi_device_probe() to prevent stale pointers
from staying around.
Signed-off-by: Michal Wilczynski <michal.wilczynski@intel.com>
[ rjw: Subject and changelog edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
| -rw-r--r-- | drivers/acpi/bus.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c index b5688839be1b..0168b3a556b6 100644 --- a/drivers/acpi/bus.c +++ b/drivers/acpi/bus.c @@ -1029,8 +1029,10 @@ static int acpi_device_probe(struct device *dev) return -ENOSYS; ret = acpi_drv->ops.add(acpi_dev); - if (ret) + if (ret) { + acpi_dev->driver_data = NULL; return ret; + } pr_debug("Driver [%s] successfully bound to device [%s]\n", acpi_drv->name, acpi_dev->pnp.bus_id); |