summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBen Hutchings <ben.hutchings@mind.be>2021-08-07 02:06:18 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-08-18 08:56:58 +0200
commit1c31ee907fde77abc1b7045d8daa8e64c1fb5d1e (patch)
tree2318965f990da9f93f60a7231bd09c846d74ecca
parentdfeb64f6e2ce28fe328a284f5a64773e407548d1 (diff)
downloadlinux-stable-1c31ee907fde77abc1b7045d8daa8e64c1fb5d1e.tar.gz
linux-stable-1c31ee907fde77abc1b7045d8daa8e64c1fb5d1e.tar.bz2
linux-stable-1c31ee907fde77abc1b7045d8daa8e64c1fb5d1e.zip
net: phy: micrel: Fix link detection on ksz87xx switch"
[ Upstream commit 2383cb9497d113360137a2be308b390faa80632d ] Commit a5e63c7d38d5 "net: phy: micrel: Fix detection of ksz87xx switch" broke link detection on the external ports of the KSZ8795. The previously unused phy_driver structure for these devices specifies config_aneg and read_status functions that appear to be designed for a fixed link and do not work with the embedded PHYs in the KSZ8795. Delete the use of these functions in favour of the generic PHY implementations which were used previously. Fixes: a5e63c7d38d5 ("net: phy: micrel: Fix detection of ksz87xx switch") Signed-off-by: Ben Hutchings <ben.hutchings@mind.be> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--drivers/net/phy/micrel.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 910ab2182158..f95bd1b0fb96 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -1184,8 +1184,6 @@ static struct phy_driver ksphy_driver[] = {
.name = "Micrel KSZ87XX Switch",
/* PHY_BASIC_FEATURES */
.config_init = kszphy_config_init,
- .config_aneg = ksz8873mll_config_aneg,
- .read_status = ksz8873mll_read_status,
.match_phy_device = ksz8795_match_phy_device,
.suspend = genphy_suspend,
.resume = genphy_resume,