summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2021-10-15 13:34:47 +0100
committerVinod Koul <vkoul@kernel.org>2021-10-18 09:38:05 +0530
commit1f6a89efbf9981a637bf472a5662e4d3746af530 (patch)
tree242d27624a1f0ea0248aa6a83d12c1b7b54cce1a
parent32de4745e20a639376735f198cccd0477f9aa396 (diff)
downloadlinux-stable-1f6a89efbf9981a637bf472a5662e4d3746af530.tar.gz
linux-stable-1f6a89efbf9981a637bf472a5662e4d3746af530.tar.bz2
linux-stable-1f6a89efbf9981a637bf472a5662e4d3746af530.zip
dmaengine: Remove redundant initialization of variable err
The variable err is being initialized with a value that is never read, it is being updated later on. The assignment is redundant and can be removed and move the declaration into the local scope. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King <colin.king@canonical.com> Link: https://lore.kernel.org/r/20211015123447.27560-1-colin.king@canonical.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
-rw-r--r--drivers/dma/dmaengine.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
index af3ee288bc11..d9f7c097cfd6 100644
--- a/drivers/dma/dmaengine.c
+++ b/drivers/dma/dmaengine.c
@@ -695,13 +695,12 @@ static struct dma_chan *find_candidate(struct dma_device *device,
*/
struct dma_chan *dma_get_slave_channel(struct dma_chan *chan)
{
- int err = -EBUSY;
-
/* lock against __dma_request_channel */
mutex_lock(&dma_list_mutex);
if (chan->client_count == 0) {
struct dma_device *device = chan->device;
+ int err;
dma_cap_set(DMA_PRIVATE, device->cap_mask);
device->privatecnt++;