diff options
| author | Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com> | 2020-02-23 20:03:02 +0530 |
|---|---|---|
| committer | Johannes Berg <johannes.berg@intel.com> | 2020-02-24 10:42:38 +0100 |
| commit | 253216ffb2a002a682c6f68bd3adff5b98b71de8 (patch) | |
| tree | 5104cb3a119b29357c683b521d57d33e76512c65 | |
| parent | e3ae39edbce6dc933fb1393490d1b5d76d3edb90 (diff) | |
| download | linux-stable-253216ffb2a002a682c6f68bd3adff5b98b71de8.tar.gz linux-stable-253216ffb2a002a682c6f68bd3adff5b98b71de8.tar.bz2 linux-stable-253216ffb2a002a682c6f68bd3adff5b98b71de8.zip | |
mac80211: rx: avoid RCU list traversal under mutex
local->sta_mtx is held in __ieee80211_check_fast_rx_iface().
No need to use list_for_each_entry_rcu() as it also requires
a cond argument to avoid false lockdep warnings when not used in
RCU read-side section (with CONFIG_PROVE_RCU_LIST).
Therefore use list_for_each_entry();
Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Link: https://lore.kernel.org/r/20200223143302.15390-1-madhuparnabhowmik10@gmail.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
| -rw-r--r-- | net/mac80211/rx.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c index 0e05ff037672..0ba98ad9bc85 100644 --- a/net/mac80211/rx.c +++ b/net/mac80211/rx.c @@ -4114,7 +4114,7 @@ void __ieee80211_check_fast_rx_iface(struct ieee80211_sub_if_data *sdata) lockdep_assert_held(&local->sta_mtx); - list_for_each_entry_rcu(sta, &local->sta_list, list) { + list_for_each_entry(sta, &local->sta_list, list) { if (sdata != sta->sdata && (!sta->sdata->bss || sta->sdata->bss != sdata->bss)) continue; |