summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJan Kiszka <jan.kiszka@siemens.com>2009-07-21 10:43:07 +0200
committerAvi Kivity <avi@redhat.com>2009-08-05 13:59:45 +0300
commit263799a3616242201e20fd2025fe84047b1379b1 (patch)
treed030af0a305b71ec547ccf6f702af8d4ca151742
parent34f0c1ad27a74bd5eb0f99ea43ab6a4658d6419d (diff)
downloadlinux-stable-263799a3616242201e20fd2025fe84047b1379b1.tar.gz
linux-stable-263799a3616242201e20fd2025fe84047b1379b1.tar.bz2
linux-stable-263799a3616242201e20fd2025fe84047b1379b1.zip
KVM: VMX: Fix locking imbalance on emulation failure
We have to disable preemption and IRQs on every exit from handle_invalid_guest_state, otherwise we generate at least a preempt_disable imbalance. Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com> Signed-off-by: Avi Kivity <avi@redhat.com>
-rw-r--r--arch/x86/kvm/vmx.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 6bf58c083f0a..29f912927a58 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -3168,7 +3168,7 @@ static void handle_invalid_guest_state(struct kvm_vcpu *vcpu,
if (err != EMULATE_DONE) {
kvm_report_emulation_failure(vcpu, "emulation failure");
- return;
+ break;
}
if (signal_pending(current))