diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2019-03-04 21:23:58 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-05-31 06:46:20 -0700 |
| commit | 267b3c6b3f45a27512f63860cc5dc84bbf57d2e1 (patch) | |
| tree | 78006d2dda0a2adc1434d27fcb40000231faf18a | |
| parent | 3ecda68846604bc8e2cc42b81d1316edaefcfa31 (diff) | |
| download | linux-stable-267b3c6b3f45a27512f63860cc5dc84bbf57d2e1.tar.gz linux-stable-267b3c6b3f45a27512f63860cc5dc84bbf57d2e1.tar.bz2 linux-stable-267b3c6b3f45a27512f63860cc5dc84bbf57d2e1.zip | |
phy: mapphone-mdm6600: add gpiolib dependency
[ Upstream commit 208d3423ee463ab257908456f6bbca4024ab63f7 ]
gcc points out that when CONFIG_GPIOLIB is disabled,
gpiod_get_array_value_cansleep() returns 0 but fails to set its output:
drivers/phy/motorola/phy-mapphone-mdm6600.c: In function 'phy_mdm6600_status':
drivers/phy/motorola/phy-mapphone-mdm6600.c:220:24: error: 'values[0]' is used uninitialized in this function [-Werror=uninitialized]
This could be fixed more generally in gpiolib by returning a failure
code, but for this specific case, the easier workaround is to add a
gpiolib dependency.
Fixes: 5d1ebbda0318 ("phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/phy/motorola/Kconfig | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/phy/motorola/Kconfig b/drivers/phy/motorola/Kconfig index 82651524ffb9..718f8729701d 100644 --- a/drivers/phy/motorola/Kconfig +++ b/drivers/phy/motorola/Kconfig @@ -13,7 +13,7 @@ config PHY_CPCAP_USB config PHY_MAPPHONE_MDM6600 tristate "Motorola Mapphone MDM6600 modem USB PHY driver" - depends on OF && USB_SUPPORT + depends on OF && USB_SUPPORT && GPIOLIB select GENERIC_PHY help Enable this for MDM6600 USB modem to work on Motorola phones |