diff options
| author | Kamalesh Babulal <kamalesh.babulal@oracle.com> | 2024-02-29 15:41:14 +0530 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-04-03 15:11:36 +0200 |
| commit | 29727355ac80b6097408c6c45f7d42839f14ad87 (patch) | |
| tree | 92d10bf26661fb95c9319d1fef4c57c424bbdf5a | |
| parent | ce64ba1f6ec3439e4b4d880b4db99673f4507228 (diff) | |
| download | linux-stable-29727355ac80b6097408c6c45f7d42839f14ad87.tar.gz linux-stable-29727355ac80b6097408c6c45f7d42839f14ad87.tar.bz2 linux-stable-29727355ac80b6097408c6c45f7d42839f14ad87.zip | |
cgroup/cpuset: Fix retval in update_cpumask()
commit 25125a4762835d62ba1e540c1351d447fc1f6c7c upstream.
The update_cpumask(), checks for newly requested cpumask by calling
validate_change(), which returns an error on passing an invalid set
of cpu(s). Independent of the error returned, update_cpumask() always
returns zero, suppressing the error and returning success to the user
on writing an invalid cpu range for a cpuset. Fix it by returning
retval instead, which is returned by validate_change().
Fixes: 99fe36ba6fc1 ("cgroup/cpuset: Improve temporary cpumasks handling")
Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Reviewed-by: Waiman Long <longman@redhat.com>
Cc: stable@vger.kernel.org # v6.6+
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | kernel/cgroup/cpuset.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index 615daaf87f1f..942346bd9cdb 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -2466,7 +2466,7 @@ static int update_cpumask(struct cpuset *cs, struct cpuset *trialcs, update_partition_sd_lb(cs, old_prs); out_free: free_cpumasks(NULL, &tmp); - return 0; + return retval; } /** |