summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBenjamin Poirier <bpoirier@suse.com>2017-07-21 11:36:25 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-11-30 08:40:59 +0000
commit2b91745f8a4accb0f04c07433ee4297054bc88b1 (patch)
tree5cbebdccbe3056534ddc59ffa22686d344b06084
parent8606bf0219f6632a931f7317dad0d4b672b1e035 (diff)
downloadlinux-stable-2b91745f8a4accb0f04c07433ee4297054bc88b1.tar.gz
linux-stable-2b91745f8a4accb0f04c07433ee4297054bc88b1.tar.bz2
linux-stable-2b91745f8a4accb0f04c07433ee4297054bc88b1.zip
e1000e: Fix return value test
commit d3509f8bc7b0560044c15f0e3ecfde1d9af757a6 upstream. All the helpers return -E1000_ERR_PHY. Signed-off-by: Benjamin Poirier <bpoirier@suse.com> Tested-by: Aaron Brown <aaron.f.brown@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: Amit Pundir <amit.pundir@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/net/ethernet/intel/e1000e/netdev.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index 327dfe5bedc0..764a6bd958ac 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -5099,7 +5099,7 @@ static bool e1000e_has_link(struct e1000_adapter *adapter)
break;
}
- if ((ret_val == E1000_ERR_PHY) && (hw->phy.type == e1000_phy_igp_3) &&
+ if ((ret_val == -E1000_ERR_PHY) && (hw->phy.type == e1000_phy_igp_3) &&
(er32(CTRL) & E1000_PHY_CTRL_GBE_DISABLE)) {
/* See e1000_kmrn_lock_loss_workaround_ich8lan() */
e_info("Gigabit has been disabled, downgrading speed\n");