diff options
| author | Yihao Han <hanyihao@vivo.com> | 2021-11-14 22:58:16 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-11-15 14:19:17 +0000 |
| commit | 311107bdecd158870ab8556fd1289a56a6087bad (patch) | |
| tree | 6825920e051f65376ac3781e37fc950065856323 | |
| parent | 9ed941178ce9894ecd0e06aebf7a3c43841817aa (diff) | |
| download | linux-stable-311107bdecd158870ab8556fd1289a56a6087bad.tar.gz linux-stable-311107bdecd158870ab8556fd1289a56a6087bad.tar.bz2 linux-stable-311107bdecd158870ab8556fd1289a56a6087bad.zip | |
net: fddi: use swap() to make code cleaner
Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
opencoding it.
Signed-off-by: Yihao Han <hanyihao@vivo.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/fddi/skfp/smt.c | 14 |
1 files changed, 4 insertions, 10 deletions
diff --git a/drivers/net/fddi/skfp/smt.c b/drivers/net/fddi/skfp/smt.c index 6b68a53f1b38..72c31f0013ad 100644 --- a/drivers/net/fddi/skfp/smt.c +++ b/drivers/net/fddi/skfp/smt.c @@ -1846,10 +1846,10 @@ void smt_swap_para(struct smt_header *sm, int len, int direction) } } + static void smt_string_swap(char *data, const char *format, int len) { const char *open_paren = NULL ; - int x ; while (len > 0 && *format) { switch (*format) { @@ -1876,19 +1876,13 @@ static void smt_string_swap(char *data, const char *format, int len) len-- ; break ; case 's' : - x = data[0] ; - data[0] = data[1] ; - data[1] = x ; + swap(data[0], data[1]) ; data += 2 ; len -= 2 ; break ; case 'l' : - x = data[0] ; - data[0] = data[3] ; - data[3] = x ; - x = data[1] ; - data[1] = data[2] ; - data[2] = x ; + swap(data[0], data[3]) ; + swap(data[1], data[2]) ; data += 4 ; len -= 4 ; break ; |