diff options
| author | huijin.park <huijin.park@samsung.com> | 2018-11-28 03:02:14 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-12-05 09:21:33 +0100 |
| commit | 37b5fff3d666fae1df038d8f9e90586e5e0e8ba1 (patch) | |
| tree | 79a3b5ab75faf859f3343ec7b5236db2ef7677f8 | |
| parent | 4535def71226e3d7f330875f1746b479baaf6bc6 (diff) | |
| download | linux-stable-37b5fff3d666fae1df038d8f9e90586e5e0e8ba1.tar.gz linux-stable-37b5fff3d666fae1df038d8f9e90586e5e0e8ba1.tar.bz2 linux-stable-37b5fff3d666fae1df038d8f9e90586e5e0e8ba1.zip | |
mtd: spi-nor: cast to u64 to avoid uint overflows
commit 84a1c2109d23df3543d96231c4fee1757299bb1a upstream.
The "params->size" is defined as "u64".
And "info->sector_size" and "info->n_sectors" are defined as
unsigned int and u16.
Thus, u64 data might have strange data(loss data) if the result
overflows an unsigned int.
This patch casts "info->sector_size" to an u64.
Signed-off-by: huijin.park <huijin.park@samsung.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/mtd/spi-nor/spi-nor.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index f028277fb1ce..2e183425facd 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -2459,7 +2459,7 @@ static int spi_nor_init_params(struct spi_nor *nor, memset(params, 0, sizeof(*params)); /* Set SPI NOR sizes. */ - params->size = info->sector_size * info->n_sectors; + params->size = (u64)info->sector_size * info->n_sectors; params->page_size = info->page_size; /* (Fast) Read settings. */ |