diff options
| author | Pavel Skripkin <paskripkin@gmail.com> | 2021-12-31 01:47:50 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-01-05 12:34:59 +0100 |
| commit | 407c8708fb1bf2d4afc5337ef50635cf540c364b (patch) | |
| tree | 215f1af3282b289a8721fe42d8b5109fcca337e9 | |
| parent | 7ad4724307435bab56da84313dc5fb85a4f57d42 (diff) | |
| download | linux-stable-407c8708fb1bf2d4afc5337ef50635cf540c364b.tar.gz linux-stable-407c8708fb1bf2d4afc5337ef50635cf540c364b.tar.bz2 linux-stable-407c8708fb1bf2d4afc5337ef50635cf540c364b.zip | |
i2c: validate user data in compat ioctl
[ Upstream commit bb436283e25aaf1533ce061605d23a9564447bdf ]
Wrong user data may cause warning in i2c_transfer(), ex: zero msgs.
Userspace should not be able to trigger warnings, so this patch adds
validation checks for user data in compact ioctl to prevent reported
warnings
Reported-and-tested-by: syzbot+e417648b303855b91d8a@syzkaller.appspotmail.com
Fixes: 7d5cb45655f2 ("i2c compat ioctls: move to ->compat_ioctl()")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/i2c/i2c-dev.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c index 57aece809841..140dd074fdee 100644 --- a/drivers/i2c/i2c-dev.c +++ b/drivers/i2c/i2c-dev.c @@ -544,6 +544,9 @@ static long compat_i2cdev_ioctl(struct file *file, unsigned int cmd, unsigned lo sizeof(rdwr_arg))) return -EFAULT; + if (!rdwr_arg.msgs || rdwr_arg.nmsgs == 0) + return -EINVAL; + if (rdwr_arg.nmsgs > I2C_RDWR_IOCTL_MAX_MSGS) return -EINVAL; |