summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorZhu Wang <wangzhu9@huawei.com>2023-08-01 19:14:21 +0800
committerMartin K. Petersen <martin.petersen@oracle.com>2023-08-07 21:34:08 -0400
commit41320b18a0e0dfb236dba4edb9be12dba1878156 (patch)
tree759e7020c2e66081966f0139e841ceddb86d3858
parent04b5b5cb0136ce970333a9c6cec7e46adba1ea3a (diff)
downloadlinux-stable-41320b18a0e0dfb236dba4edb9be12dba1878156.tar.gz
linux-stable-41320b18a0e0dfb236dba4edb9be12dba1878156.tar.bz2
linux-stable-41320b18a0e0dfb236dba4edb9be12dba1878156.zip
scsi: snic: Fix possible memory leak if device_add() fails
If device_add() returns error, the name allocated by dev_set_name() needs be freed. As the comment of device_add() says, put_device() should be used to give up the reference in the error path. So fix this by calling put_device(), then the name can be freed in kobject_cleanp(). Fixes: c8806b6c9e82 ("snic: driver for Cisco SCSI HBA") Signed-off-by: Zhu Wang <wangzhu9@huawei.com> Acked-by: Narsimhulu Musini <nmusini@cisco.com> Link: https://lore.kernel.org/r/20230801111421.63651-1-wangzhu9@huawei.com Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
-rw-r--r--drivers/scsi/snic/snic_disc.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/scsi/snic/snic_disc.c b/drivers/scsi/snic/snic_disc.c
index 3e2e5783924d..e429ad23c396 100644
--- a/drivers/scsi/snic/snic_disc.c
+++ b/drivers/scsi/snic/snic_disc.c
@@ -303,6 +303,7 @@ snic_tgt_create(struct snic *snic, struct snic_tgt_id *tgtid)
"Snic Tgt: device_add, with err = %d\n",
ret);
+ put_device(&tgt->dev);
put_device(&snic->shost->shost_gendev);
spin_lock_irqsave(snic->shost->host_lock, flags);
list_del(&tgt->list);