summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRavi Bangoria <ravi.bangoria@linux.ibm.com>2020-09-02 09:59:39 +0530
committerMichael Ellerman <mpe@ellerman.id.au>2020-09-15 22:13:18 +1000
commit4441eb02333a9b46a0d919aa7a6d3b137b5f2562 (patch)
tree2fbf40cc8c367b0ba1b3e0d9afac9c69fca41719
parent4759c11ed20454b7b36db4ec15f7d5aa1519af4a (diff)
downloadlinux-stable-4441eb02333a9b46a0d919aa7a6d3b137b5f2562.tar.gz
linux-stable-4441eb02333a9b46a0d919aa7a6d3b137b5f2562.tar.bz2
linux-stable-4441eb02333a9b46a0d919aa7a6d3b137b5f2562.zip
powerpc/watchpoint: Fix handling of vector instructions
Vector load/store instructions are special because they are always aligned. Thus unaligned EA needs to be aligned down before comparing it with watch ranges. Otherwise we might consider valid event as invalid. Fixes: 74c6881019b7 ("powerpc/watchpoint: Prepare handler to handle more than one watchpoint") Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://lore.kernel.org/r/20200902042945.129369-3-ravi.bangoria@linux.ibm.com
-rw-r--r--arch/powerpc/kernel/hw_breakpoint.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/arch/powerpc/kernel/hw_breakpoint.c b/arch/powerpc/kernel/hw_breakpoint.c
index 9f7df1c37233..f6b24838ca3c 100644
--- a/arch/powerpc/kernel/hw_breakpoint.c
+++ b/arch/powerpc/kernel/hw_breakpoint.c
@@ -644,6 +644,8 @@ static void get_instr_detail(struct pt_regs *regs, struct ppc_inst *instr,
if (*type == CACHEOP) {
*size = cache_op_size();
*ea &= ~(*size - 1);
+ } else if (*type == LOAD_VMX || *type == STORE_VMX) {
+ *ea &= ~(*size - 1);
}
}