diff options
| author | Valtteri Heikkilä <rnd@nic.fi> | 2017-02-14 23:14:32 +0000 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2018-11-20 18:05:59 +0000 |
| commit | 4628582178bf13565593c9ff432cdaf90864e5e5 (patch) | |
| tree | 1f8377d2be4daf466389a68d807290bae36667f5 | |
| parent | d4de72aae6f0cb27a863cb5a2292a6d2ae680ce1 (diff) | |
| download | linux-stable-4628582178bf13565593c9ff432cdaf90864e5e5.tar.gz linux-stable-4628582178bf13565593c9ff432cdaf90864e5e5.tar.bz2 linux-stable-4628582178bf13565593c9ff432cdaf90864e5e5.zip | |
HID: reject input outside logical range only if null state is set
commit 3f3752705dbd50b66b66ad7b4d54fe33d2f746ed upstream.
This patch fixes an issue in drivers/hid/hid-input.c where USB HID
control null state flag is not checked upon rejecting inputs outside
logical minimum-maximum range. The check should be made according to USB
HID specification 1.11, section 6.2.2.5, p.31. The fix will resolve
issues with some game controllers, such as:
https://bugzilla.kernel.org/show_bug.cgi?id=68621
[tk@the-tk.com: shortened and fixed spelling in commit message]
Signed-off-by: Valtteri Heikkilä <rnd@nic.fi>
Signed-off-by: Tomasz Kramkowski <tk@the-tk.com>
Acked-By: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | drivers/hid/hid-input.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c index ee1af4565828..a4121e441add 100644 --- a/drivers/hid/hid-input.c +++ b/drivers/hid/hid-input.c @@ -1094,6 +1094,7 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct * don't specify logical min and max. */ if ((field->flags & HID_MAIN_ITEM_VARIABLE) && + (field->flags & HID_MAIN_ITEM_NULL_STATE) && (field->logical_minimum < field->logical_maximum) && (value < field->logical_minimum || value > field->logical_maximum)) { |