diff options
| author | Shawn Guo <shawn.guo@linaro.org> | 2021-03-17 14:36:06 +0800 |
|---|---|---|
| committer | Ard Biesheuvel <ardb@kernel.org> | 2021-03-17 09:40:24 +0100 |
| commit | 483028edacab374060d93955382b4865a9e07cba (patch) | |
| tree | 61673bc7d53917e5446402f3148a0b7dd029db13 | |
| parent | 9e9888a0fe97b9501a40f717225d2bef7100a2c1 (diff) | |
| download | linux-stable-483028edacab374060d93955382b4865a9e07cba.tar.gz linux-stable-483028edacab374060d93955382b4865a9e07cba.tar.bz2 linux-stable-483028edacab374060d93955382b4865a9e07cba.zip | |
efivars: respect EFI_UNSUPPORTED return from firmware
As per UEFI spec 2.8B section 8.2, EFI_UNSUPPORTED may be returned by
EFI variable runtime services if no variable storage is supported by
firmware. In this case, there is no point for kernel to continue
efivars initialization. That said, efivar_init() should fail by
returning an error code, so that efivarfs will not be mounted on
/sys/firmware/efi/efivars at all. Otherwise, user space like efibootmgr
will be confused by the EFIVARFS_MAGIC seen there, while EFI variable
calls cannot be made successfully.
Cc: <stable@vger.kernel.org> # v5.10+
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
| -rw-r--r-- | drivers/firmware/efi/vars.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/firmware/efi/vars.c b/drivers/firmware/efi/vars.c index 41c1d00bf933..abdc8a6a3963 100644 --- a/drivers/firmware/efi/vars.c +++ b/drivers/firmware/efi/vars.c @@ -485,6 +485,10 @@ int efivar_init(int (*func)(efi_char16_t *, efi_guid_t, unsigned long, void *), } break; + case EFI_UNSUPPORTED: + err = -EOPNOTSUPP; + status = EFI_NOT_FOUND; + break; case EFI_NOT_FOUND: break; default: |