diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2024-09-05 16:28:59 +0300 |
|---|---|---|
| committer | Sebastian Reichel <sebastian.reichel@collabora.com> | 2024-09-05 16:30:37 +0200 |
| commit | 48f703d6a3d7cf345fe9c6209ea3703fe9024628 (patch) | |
| tree | ef2da31e3250b387d872579f8fa72ac316508bb8 | |
| parent | 6625767049c2e0960ba9835392a6ef9143170be6 (diff) | |
| download | linux-stable-48f703d6a3d7cf345fe9c6209ea3703fe9024628.tar.gz linux-stable-48f703d6a3d7cf345fe9c6209ea3703fe9024628.tar.bz2 linux-stable-48f703d6a3d7cf345fe9c6209ea3703fe9024628.zip | |
power: supply: max1720x: fix a double free on error in probe()
In this code, if devm_add_action_or_reset() fails, it will call
max1720x_unregister_ancillary() which in turn calls
i2c_unregister_device(). Thus the call to i2c_unregister_device() on the
following line is not required and is a double unregister. Delete it.
Fixes: 47271a935619 ("power: supply: max1720x: add read support for nvmem")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/9c2f76e7-5679-473b-9b9c-e11b492b96ac@stanley.mountain
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
| -rw-r--r-- | drivers/power/supply/max1720x_battery.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/power/supply/max1720x_battery.c b/drivers/power/supply/max1720x_battery.c index 3e84e70340e4..2bc3dce963a3 100644 --- a/drivers/power/supply/max1720x_battery.c +++ b/drivers/power/supply/max1720x_battery.c @@ -427,7 +427,6 @@ static int max1720x_probe_nvmem(struct i2c_client *client, ret = devm_add_action_or_reset(dev, max1720x_unregister_ancillary, info); if (ret) { - i2c_unregister_device(info->ancillary); dev_err(dev, "Failed to add unregister callback\n"); return ret; } |