summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>2023-02-12 07:51:51 +0100
committerJakub Kicinski <kuba@kernel.org>2023-02-13 19:45:46 -0800
commit511b88fedab459205693dc4bc2ad690fb0dd89ea (patch)
treecac9d04453db18983183d12e83f8708265dbedd0
parentef01749f6a0d3d77e18488263fa920c49a001bfb (diff)
downloadlinux-stable-511b88fedab459205693dc4bc2ad690fb0dd89ea.tar.gz
linux-stable-511b88fedab459205693dc4bc2ad690fb0dd89ea.tar.bz2
linux-stable-511b88fedab459205693dc4bc2ad690fb0dd89ea.zip
net: ethernet: mtk_wed: No need to clear memory after a dma_alloc_coherent() call
dma_alloc_coherent() already clears the allocated memory, there is no need to explicitly call memset(). Moreover, it is likely that the size in the memset() is incorrect and should be "size * sizeof(*ring->desc)". Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Link: https://lore.kernel.org/r/d5acce7dd108887832c9719f62c7201b4c83b3fb.1676184599.git.christophe.jaillet@wanadoo.fr Signed-off-by: Jakub Kicinski <kuba@kernel.org>
-rw-r--r--drivers/net/ethernet/mediatek/mtk_wed.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mediatek/mtk_wed.c b/drivers/net/ethernet/mediatek/mtk_wed.c
index 95ac4f71d2b2..95d890870984 100644
--- a/drivers/net/ethernet/mediatek/mtk_wed.c
+++ b/drivers/net/ethernet/mediatek/mtk_wed.c
@@ -787,7 +787,6 @@ mtk_wed_rro_ring_alloc(struct mtk_wed_device *dev, struct mtk_wed_ring *ring,
ring->desc_size = sizeof(*ring->desc);
ring->size = size;
- memset(ring->desc, 0, size);
return 0;
}