diff options
author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2020-02-28 22:38:38 +0100 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2020-03-02 15:03:19 +0000 |
commit | 51bddd4501bc414b8b1e8f4d096b4a5304068169 (patch) | |
tree | 04a677075262074c4f491cec15c9244e4c033804 | |
parent | 8e093ea4d3593379be46b845b9e823179558047e (diff) | |
download | linux-stable-51bddd4501bc414b8b1e8f4d096b4a5304068169.tar.gz linux-stable-51bddd4501bc414b8b1e8f4d096b4a5304068169.tar.bz2 linux-stable-51bddd4501bc414b8b1e8f4d096b4a5304068169.zip |
spi: bcm63xx-hsspi: Really keep pll clk enabled
The purpose of commit 0fd85869c2a9 ("spi/bcm63xx-hsspi: keep pll clk enabled")
was to keep the pll clk enabled through the lifetime of the device.
In order to do that, some 'clk_prepare_enable()'/'clk_disable_unprepare()'
calls have been added in the error handling path of the probe function, in
the remove function and in the suspend and resume functions.
However, a 'clk_disable_unprepare()' call has been unfortunately left in
the probe function. So the commit seems to be more or less a no-op.
Axe it now, so that the pll clk is left enabled through the lifetime of
the device, as described in the commit.
Fixes: 0fd85869c2a9 ("spi/bcm63xx-hsspi: keep pll clk enabled")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Jonas Gorski <jonas.gorski@gmail.com>
Link: https://lore.kernel.org/r/20200228213838.7124-1-christophe.jaillet@wanadoo.fr
Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r-- | drivers/spi/spi-bcm63xx-hsspi.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/spi/spi-bcm63xx-hsspi.c b/drivers/spi/spi-bcm63xx-hsspi.c index 7327309ea3d5..6c235306c0e4 100644 --- a/drivers/spi/spi-bcm63xx-hsspi.c +++ b/drivers/spi/spi-bcm63xx-hsspi.c @@ -366,7 +366,6 @@ static int bcm63xx_hsspi_probe(struct platform_device *pdev) goto out_disable_clk; rate = clk_get_rate(pll_clk); - clk_disable_unprepare(pll_clk); if (!rate) { ret = -EINVAL; goto out_disable_pll_clk; |