diff options
| author | Tom Rix <trix@redhat.com> | 2020-07-19 17:34:47 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2020-09-01 14:13:27 +0200 |
| commit | 52438c4463ac904d14bf3496765e67750766f3a6 (patch) | |
| tree | b42de4b09028e3825ddd1cb32fe5f69169192dcd | |
| parent | e5b95c8febd504659b60a7601fd43c0ae8e4f3c0 (diff) | |
| download | linux-stable-52438c4463ac904d14bf3496765e67750766f3a6.tar.gz linux-stable-52438c4463ac904d14bf3496765e67750766f3a6.tar.bz2 linux-stable-52438c4463ac904d14bf3496765e67750766f3a6.zip | |
media: m5mols: Check function pointer in m5mols_sensor_power
clang static analysis reports this error
m5mols_core.c:767:4: warning: Called function pointer
is null (null dereference) [core.CallAndMessage]
info->set_power(&client->dev, 0);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In other places, the set_power ptr is checked.
So add a check.
Fixes: bc125106f8af ("[media] Add support for M-5MOLS 8 Mega Pixel camera ISP")
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
| -rw-r--r-- | drivers/media/i2c/m5mols/m5mols_core.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/media/i2c/m5mols/m5mols_core.c b/drivers/media/i2c/m5mols/m5mols_core.c index de295114ca48..21666d705e37 100644 --- a/drivers/media/i2c/m5mols/m5mols_core.c +++ b/drivers/media/i2c/m5mols/m5mols_core.c @@ -764,7 +764,8 @@ static int m5mols_sensor_power(struct m5mols_info *info, bool enable) ret = regulator_bulk_enable(ARRAY_SIZE(supplies), supplies); if (ret) { - info->set_power(&client->dev, 0); + if (info->set_power) + info->set_power(&client->dev, 0); return ret; } |