diff options
| author | Nicolas Iooss <nicolas.iooss_linux@m4x.org> | 2016-09-10 13:59:49 -0300 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2017-03-16 02:26:17 +0000 |
| commit | 5c04a2622839a8a2246d9b74ced2e6a18d53c7c5 (patch) | |
| tree | e5746dddb8b6d4a6742d5066cb8811dff0d2e4dc | |
| parent | cd689fbaf382475212258942a49ddf00da70c993 (diff) | |
| download | linux-stable-5c04a2622839a8a2246d9b74ced2e6a18d53c7c5.tar.gz linux-stable-5c04a2622839a8a2246d9b74ced2e6a18d53c7c5.tar.bz2 linux-stable-5c04a2622839a8a2246d9b74ced2e6a18d53c7c5.zip | |
ite-cir: initialize use_demodulator before using it
commit 7ec03e60ef81c19b5d3a46dd070ee966774b860f upstream.
Function ite_set_carrier_params() uses variable use_demodulator after
having initialized it to false in some if branches, but this variable is
never set to true otherwise.
This bug has been found using clang -Wsometimes-uninitialized warning
flag.
Fixes: 620a32bba4a2 ("[media] rc: New rc-based ite-cir driver for
several ITE CIRs")
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | drivers/media/rc/ite-cir.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/media/rc/ite-cir.c b/drivers/media/rc/ite-cir.c index ab24cc6d3655..65740093403e 100644 --- a/drivers/media/rc/ite-cir.c +++ b/drivers/media/rc/ite-cir.c @@ -263,6 +263,8 @@ static void ite_set_carrier_params(struct ite_dev *dev) if (allowance > ITE_RXDCR_MAX) allowance = ITE_RXDCR_MAX; + + use_demodulator = true; } } |