diff options
| author | Hans Verkuil <hverkuil-cisco@xs4all.nl> | 2024-09-02 10:31:23 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2024-10-12 15:53:42 +0200 |
| commit | 5e53592063f344658d0876b448a2e5ec09a9883d (patch) | |
| tree | a5c8e6544c5a347a7bc65199fc8cbb3a3eae276a | |
| parent | 6ce4c5dc5dd2706d1821d8ebdc53afad8182c2d5 (diff) | |
| download | linux-stable-5e53592063f344658d0876b448a2e5ec09a9883d.tar.gz linux-stable-5e53592063f344658d0876b448a2e5ec09a9883d.tar.bz2 linux-stable-5e53592063f344658d0876b448a2e5ec09a9883d.zip | |
media: pisp_be: add missing wait_prepare/finish ops
Without these ops the v4l2-compliance blocking wait test will fail.
These ops are required to ensure that when VIDIOC_DQBUF has to
wait for buffers to arrive, the queue lock is correctly released
and retaken. Otherwise the wait for a buffer would block all other
queue ioctls.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Tested-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
| -rw-r--r-- | drivers/media/platform/raspberrypi/pisp_be/pisp_be.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c b/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c index 65ff2382cffe..7ce3be626c4a 100644 --- a/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c +++ b/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c @@ -964,6 +964,8 @@ static const struct vb2_ops pispbe_node_queue_ops = { .buf_queue = pispbe_node_buffer_queue, .start_streaming = pispbe_node_start_streaming, .stop_streaming = pispbe_node_stop_streaming, + .wait_prepare = vb2_ops_wait_prepare, + .wait_finish = vb2_ops_wait_finish, }; static const struct v4l2_file_operations pispbe_fops = { |