diff options
author | Hans Verkuil <hverkuil-cisco@xs4all.nl> | 2023-02-01 12:48:54 +0100 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@kernel.org> | 2023-03-19 22:10:23 +0100 |
commit | 5f225889f23db9ddabf6eca82bebb760b283705b (patch) | |
tree | 3efb3ac3b23490743fa3d54d99ebd36ce3928ec1 | |
parent | 2f8c0810af739ec3587d00bf36cc5a6a0139be1a (diff) | |
download | linux-stable-5f225889f23db9ddabf6eca82bebb760b283705b.tar.gz linux-stable-5f225889f23db9ddabf6eca82bebb760b283705b.tar.bz2 linux-stable-5f225889f23db9ddabf6eca82bebb760b283705b.zip |
media: v4l2-dev.c: check for V4L2_CAP_STREAMING to enable streaming ioctls
Rather than checking which device type it is, just check the STREAMING
cap since that indicates support for streaming ioctls.
Some drivers only support READWRITE (typically MPEG encoders).
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
-rw-r--r-- | drivers/media/v4l2-core/v4l2-dev.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/media/v4l2-core/v4l2-dev.c b/drivers/media/v4l2-core/v4l2-dev.c index 397d553177fa..f81279492682 100644 --- a/drivers/media/v4l2-core/v4l2-dev.c +++ b/drivers/media/v4l2-core/v4l2-dev.c @@ -556,6 +556,7 @@ static void determine_valid_ioctls(struct video_device *vdev) bool is_rx = vdev->vfl_dir != VFL_DIR_TX; bool is_tx = vdev->vfl_dir != VFL_DIR_RX; bool is_io_mc = vdev->device_caps & V4L2_CAP_IO_MC; + bool has_streaming = vdev->device_caps & V4L2_CAP_STREAMING; bitmap_zero(valid_ioctls, BASE_VIDIOC_PRIVATE); @@ -708,8 +709,8 @@ static void determine_valid_ioctls(struct video_device *vdev) SET_VALID_IOCTL(ops, VIDIOC_TRY_FMT, vidioc_try_fmt_sdr_out); } - if (is_vid || is_vbi || is_sdr || is_tch || is_meta) { - /* ioctls valid for video, vbi, sdr, touch and metadata */ + if (has_streaming) { + /* ioctls valid for streaming I/O */ SET_VALID_IOCTL(ops, VIDIOC_REQBUFS, vidioc_reqbufs); SET_VALID_IOCTL(ops, VIDIOC_QUERYBUF, vidioc_querybuf); SET_VALID_IOCTL(ops, VIDIOC_QBUF, vidioc_qbuf); |