summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2024-01-03 16:58:05 +0100
committerMauro Carvalho Chehab <mchehab@kernel.org>2024-01-11 18:43:04 +0100
commit60a031b64984ad4a219a13b0fe912746b586bb9b (patch)
treefca25ba0e209e5623f4b5911104ceae74fe69b63
parent02d4e62ae2452c83e4a3e279b8e4cb4dcbad4b31 (diff)
downloadlinux-stable-60a031b64984ad4a219a13b0fe912746b586bb9b.tar.gz
linux-stable-60a031b64984ad4a219a13b0fe912746b586bb9b.tar.bz2
linux-stable-60a031b64984ad4a219a13b0fe912746b586bb9b.zip
media: i2c: thp7312: select CONFIG_FW_LOADER
The recently added driver uses the firmware loader mechanism but causes a link failure when that is in a loadable module while thp7312 itself is built-in: arm-linux-gnueabi-ld: drivers/media/i2c/thp7312.o: in function `thp7312_probe': thp7312.c:(.text+0x4164): undefined reference to `firmware_upload_register' Select the required Kconfig symbol. Note that the driver specifically needs the firmware upload interface that is controlled by CONFIG_FW_UPLOAD, but there is no link failure when that is disabled because the interfaces are stubbed out here. Link: https://lore.kernel.org/linux-media/20240103155811.4092035-1-arnd@kernel.org Fixes: 7a52ab415b43 ("media: i2c: Add driver for THine THP7312") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
-rw-r--r--drivers/media/i2c/Kconfig1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index 78a87331686e..4c3435921f19 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -674,6 +674,7 @@ menu "Camera ISPs"
config VIDEO_THP7312
tristate "THine THP7312 support"
depends on I2C
+ select FW_LOADER
select MEDIA_CONTROLLER
select V4L2_CCI_I2C
select V4L2_FWNODE