diff options
| author | Zhang Changzhong <zhangchangzhong@huawei.com> | 2022-11-17 16:50:38 +0800 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2022-11-18 19:39:05 -0800 |
| commit | 62a7311fb96c61d281da9852dbee4712fc8c3277 (patch) | |
| tree | 11a0b88a7d036f5456b84014d532d04c1b0be415 | |
| parent | cbe867685386af1f0a2648f5279f6e4c74bfd17f (diff) | |
| download | linux-stable-62a7311fb96c61d281da9852dbee4712fc8c3277.tar.gz linux-stable-62a7311fb96c61d281da9852dbee4712fc8c3277.tar.bz2 linux-stable-62a7311fb96c61d281da9852dbee4712fc8c3277.zip | |
net/qla3xxx: fix potential memleak in ql3xxx_send()
The ql3xxx_send() returns NETDEV_TX_OK without freeing skb in error
handling case, add dev_kfree_skb_any() to fix it.
Fixes: bd36b0ac5d06 ("qla3xxx: Add support for Qlogic 4032 chip.")
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Link: https://lore.kernel.org/r/1668675039-21138-1-git-send-email-zhangchangzhong@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | drivers/net/ethernet/qlogic/qla3xxx.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/qlogic/qla3xxx.c b/drivers/net/ethernet/qlogic/qla3xxx.c index 76072f8c3d2f..0d57ffcedf0c 100644 --- a/drivers/net/ethernet/qlogic/qla3xxx.c +++ b/drivers/net/ethernet/qlogic/qla3xxx.c @@ -2471,6 +2471,7 @@ static netdev_tx_t ql3xxx_send(struct sk_buff *skb, skb_shinfo(skb)->nr_frags); if (tx_cb->seg_count == -1) { netdev_err(ndev, "%s: invalid segment count!\n", __func__); + dev_kfree_skb_any(skb); return NETDEV_TX_OK; } |