diff options
| author | Dmitry Antipov <dmantipov@yandex.ru> | 2023-06-28 10:23:15 +0300 |
|---|---|---|
| committer | Kalle Valo <kvalo@kernel.org> | 2023-07-25 17:40:43 +0300 |
| commit | 634fcbcaa4062db39aeb5ac6ed1bc1feb8dd5216 (patch) | |
| tree | a3cf0aeb224760e9f4898cdbc1f2e087f167257f | |
| parent | f5f80e32de12fad2813d37270e8364a03e6d3ef0 (diff) | |
| download | linux-stable-634fcbcaa4062db39aeb5ac6ed1bc1feb8dd5216.tar.gz linux-stable-634fcbcaa4062db39aeb5ac6ed1bc1feb8dd5216.tar.bz2 linux-stable-634fcbcaa4062db39aeb5ac6ed1bc1feb8dd5216.zip | |
wifi: rtw88: delete timer and free skb queue when unloading
Fix possible crash and memory leak on driver unload by deleting
TX purge timer and freeing C2H queue in 'rtw_core_deinit()',
shrink critical section in the latter by freeing COEX queue
out of TX report lock scope.
Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230628072327.167196-1-dmantipov@yandex.ru
| -rw-r--r-- | drivers/net/wireless/realtek/rtw88/main.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/wireless/realtek/rtw88/main.c b/drivers/net/wireless/realtek/rtw88/main.c index c853e2f2d448..c2ddb4d382af 100644 --- a/drivers/net/wireless/realtek/rtw88/main.c +++ b/drivers/net/wireless/realtek/rtw88/main.c @@ -2183,10 +2183,12 @@ void rtw_core_deinit(struct rtw_dev *rtwdev) release_firmware(wow_fw->firmware); destroy_workqueue(rtwdev->tx_wq); + timer_delete_sync(&rtwdev->tx_report.purge_timer); spin_lock_irqsave(&rtwdev->tx_report.q_lock, flags); skb_queue_purge(&rtwdev->tx_report.queue); - skb_queue_purge(&rtwdev->coex.queue); spin_unlock_irqrestore(&rtwdev->tx_report.q_lock, flags); + skb_queue_purge(&rtwdev->coex.queue); + skb_queue_purge(&rtwdev->c2h_queue); list_for_each_entry_safe(rsvd_pkt, tmp, &rtwdev->rsvd_page_list, build_list) { |