diff options
author | Anson Huang <Anson.Huang@nxp.com> | 2020-08-17 15:34:33 +0800 |
---|---|---|
committer | Guenter Roeck <linux@roeck-us.net> | 2020-09-23 09:42:40 -0700 |
commit | 65b2aad0699b3915cc3a5afee0a382eda0fc93b5 (patch) | |
tree | 8fac6d7c56a577afd66567d9a65ecf959ae3f1ea | |
parent | 4e1b4d22279188e63546838144399a6dde44a5aa (diff) | |
download | linux-stable-65b2aad0699b3915cc3a5afee0a382eda0fc93b5.tar.gz linux-stable-65b2aad0699b3915cc3a5afee0a382eda0fc93b5.tar.bz2 linux-stable-65b2aad0699b3915cc3a5afee0a382eda0fc93b5.zip |
hwmon: (pwm-fan) Use dev_err_probe() to simplify error handling
dev_err_probe() can reduce code size, uniform error handling and record the
defer probe reason etc., use it to simplify the code.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Link: https://lore.kernel.org/r/1597649673-22329-1-git-send-email-Anson.Huang@nxp.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
-rw-r--r-- | drivers/hwmon/pwm-fan.c | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c index 17bb64299bfd..bdba2143021a 100644 --- a/drivers/hwmon/pwm-fan.c +++ b/drivers/hwmon/pwm-fan.c @@ -293,14 +293,8 @@ static int pwm_fan_probe(struct platform_device *pdev) mutex_init(&ctx->lock); ctx->pwm = devm_of_pwm_get(dev, dev->of_node, NULL); - if (IS_ERR(ctx->pwm)) { - ret = PTR_ERR(ctx->pwm); - - if (ret != -EPROBE_DEFER) - dev_err(dev, "Could not get PWM: %d\n", ret); - - return ret; - } + if (IS_ERR(ctx->pwm)) + return dev_err_probe(dev, PTR_ERR(ctx->pwm), "Could not get PWM\n"); platform_set_drvdata(pdev, ctx); |