summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Arcari <darcari@redhat.com>2023-10-05 07:17:57 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-11-28 17:15:05 +0000
commit6a3866dbdcf39ac93e98708e6abced511733dc18 (patch)
tree5743271affd89179695955632833d89de7575a8a
parent5b2ed3c04a06ac6fbc1eb74e4b45823695c20ccf (diff)
downloadlinux-stable-6a3866dbdcf39ac93e98708e6abced511733dc18.tar.gz
linux-stable-6a3866dbdcf39ac93e98708e6abced511733dc18.tar.bz2
linux-stable-6a3866dbdcf39ac93e98708e6abced511733dc18.zip
thermal: intel: powerclamp: fix mismatch in get function for max_idle
commit fae633cfb729da2771b5433f6b84ae7e8b4aa5f7 upstream. KASAN reported this [ 444.853098] BUG: KASAN: global-out-of-bounds in param_get_int+0x77/0x90 [ 444.853111] Read of size 4 at addr ffffffffc16c9220 by task cat/2105 ... [ 444.853442] The buggy address belongs to the variable: [ 444.853443] max_idle+0x0/0xffffffffffffcde0 [intel_powerclamp] There is a mismatch between the param_get_int and the definition of max_idle. Replacing param_get_int with param_get_byte resolves this issue. Fixes: ebf519710218 ("thermal: intel: powerclamp: Add two module parameters") Cc: 6.3+ <stable@vger.kernel.org> # 6.3+ Signed-off-by: David Arcari <darcari@redhat.com> Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/thermal/intel/intel_powerclamp.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/thermal/intel/intel_powerclamp.c b/drivers/thermal/intel/intel_powerclamp.c
index 36243a3972fd..5ac5cb60bae6 100644
--- a/drivers/thermal/intel/intel_powerclamp.c
+++ b/drivers/thermal/intel/intel_powerclamp.c
@@ -256,7 +256,7 @@ skip_limit_set:
static const struct kernel_param_ops max_idle_ops = {
.set = max_idle_set,
- .get = param_get_int,
+ .get = param_get_byte,
};
module_param_cb(max_idle, &max_idle_ops, &max_idle, 0644);