summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlexandru Ardelean <aardelean@deviqon.com>2021-05-15 10:59:05 +0300
committerBartosz Golaszewski <bgolaszewski@baylibre.com>2021-05-23 20:35:17 +0200
commit6e153938b7f005fde4dd025e3998d94cb27e4148 (patch)
tree2cc8dad7cad0f4458cf041615d8d44f6ea6b367f
parent10a476164b08067f2094020f812af52c347542de (diff)
downloadlinux-stable-6e153938b7f005fde4dd025e3998d94cb27e4148.tar.gz
linux-stable-6e153938b7f005fde4dd025e3998d94cb27e4148.tar.bz2
linux-stable-6e153938b7f005fde4dd025e3998d94cb27e4148.zip
gpio: gpio-tegra186: remove platform_set_drvdata() + cleanup probe
The platform_set_drvdata() call is only useful if we need to retrieve back the private information. Since the driver doesn't do that, it's not useful to have it. If this is removed, we can also just do a direct return on devm_gpiochip_add_data(). We don't need to print that this call failed as there are other ways to log/see this during probe. Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
-rw-r--r--drivers/gpio/gpio-tegra186.c8
1 files changed, 1 insertions, 7 deletions
diff --git a/drivers/gpio/gpio-tegra186.c b/drivers/gpio/gpio-tegra186.c
index 10d3597e9ac2..f54ae9d4254a 100644
--- a/drivers/gpio/gpio-tegra186.c
+++ b/drivers/gpio/gpio-tegra186.c
@@ -741,13 +741,7 @@ static int tegra186_gpio_probe(struct platform_device *pdev)
offset += port->pins;
}
- platform_set_drvdata(pdev, gpio);
-
- err = devm_gpiochip_add_data(&pdev->dev, &gpio->gpio, gpio);
- if (err < 0)
- return err;
-
- return 0;
+ return devm_gpiochip_add_data(&pdev->dev, &gpio->gpio, gpio);
}
#define TEGRA186_MAIN_GPIO_PORT(_name, _bank, _port, _pins) \