diff options
| author | Colin Ian King <colin.king@canonical.com> | 2017-03-07 11:30:47 -0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@s-opensource.com> | 2017-04-05 15:06:38 -0300 |
| commit | 6ea87867e552500b242cd5be3590d6c1ff91f508 (patch) | |
| tree | 199c867c788f25d122a79f9526053d20f41f5bfb | |
| parent | 946c41af8fad4140d3721f736679c417ae5bc21a (diff) | |
| download | linux-stable-6ea87867e552500b242cd5be3590d6c1ff91f508.tar.gz linux-stable-6ea87867e552500b242cd5be3590d6c1ff91f508.tar.bz2 linux-stable-6ea87867e552500b242cd5be3590d6c1ff91f508.zip | |
[media] atmel-isc: fix off-by-one comparison and out of bounds read issue
The are only HIST_ENTRIES worth of entries in hist_entry however the
for-loop is iterating one too many times leasing to a read access off
the end off the array ctrls->hist_entry. Fix this by iterating by
the correct number of times.
Detected by CoverityScan, CID#1415279 ("Out-of-bounds read")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Hans Verkuil <hansverk@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
| -rw-r--r-- | drivers/media/platform/atmel/atmel-isc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers/media/platform/atmel/atmel-isc.c index b380a7d40d85..7dacf8c1354f 100644 --- a/drivers/media/platform/atmel/atmel-isc.c +++ b/drivers/media/platform/atmel/atmel-isc.c @@ -1298,7 +1298,7 @@ static void isc_hist_count(struct isc_device *isc) regmap_bulk_read(regmap, ISC_HIS_ENTRY, hist_entry, HIST_ENTRIES); *hist_count = 0; - for (i = 0; i <= HIST_ENTRIES; i++) + for (i = 0; i < HIST_ENTRIES; i++) *hist_count += i * (*hist_entry++); } |