summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@linaro.org>2024-09-05 16:17:06 +0300
committerUlf Hansson <ulf.hansson@linaro.org>2024-09-09 12:22:06 +0200
commit73048a832587520c6222bacbe1bc7121409d8861 (patch)
tree2d8640d37afb1cd9130e633d29802a1204fe8aa3
parentcf6444ba528f043398b112ac36e041a4d8685cb1 (diff)
downloadlinux-stable-73048a832587520c6222bacbe1bc7121409d8861.tar.gz
linux-stable-73048a832587520c6222bacbe1bc7121409d8861.tar.bz2
linux-stable-73048a832587520c6222bacbe1bc7121409d8861.zip
optee: Fix a NULL vs IS_ERR() check
The tee_shm_get_va() function never returns NULL, it returns error pointers. Update the check to match. Fixes: f0c8431568ee ("optee: probe RPMB device using RPMB subsystem") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org> Link: https://lore.kernel.org/r/f8c12aed-b5d1-4522-bf95-622b8569706d@stanley.mountain Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
-rw-r--r--drivers/tee/optee/rpc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/tee/optee/rpc.c b/drivers/tee/optee/rpc.c
index a4b49fd1d46d..ebbbd42b0e3e 100644
--- a/drivers/tee/optee/rpc.c
+++ b/drivers/tee/optee/rpc.c
@@ -332,7 +332,7 @@ static void handle_rpc_func_rpmb_probe_next(struct tee_context *ctx,
}
buf = tee_shm_get_va(params[1].u.memref.shm,
params[1].u.memref.shm_offs);
- if (!buf) {
+ if (IS_ERR(buf)) {
arg->ret = TEEC_ERROR_BAD_PARAMETERS;
return;
}