diff options
author | Alexander Aring <aahringo@redhat.com> | 2023-01-12 17:10:33 -0500 |
---|---|---|
committer | David Teigland <teigland@redhat.com> | 2023-01-23 12:57:18 -0600 |
commit | 7354fa4ef697191effedc2ae9a8293427708bbf5 (patch) | |
tree | 711ab6fe4991154fff8da4798d442f76115e8a2b | |
parent | 724b6bab0d75f1dc01fdfbf7fe8d4217a5cb90ba (diff) | |
download | linux-stable-7354fa4ef697191effedc2ae9a8293427708bbf5.tar.gz linux-stable-7354fa4ef697191effedc2ae9a8293427708bbf5.tar.bz2 linux-stable-7354fa4ef697191effedc2ae9a8293427708bbf5.zip |
fs: dlm: be sure to call dlm_send_queue_flush()
If we release a midcomms node structure, there should be nothing left
inside the dlm midcomms send queue. However, sometimes this is not true
because I believe some DLM_FIN message was not acked... if we run
into a shutdown timeout, then we should be sure there is no pending send
dlm message inside this queue when releasing midcomms node structure.
Cc: stable@vger.kernel.org
Fixes: 489d8e559c65 ("fs: dlm: add reliable connection if reconnect")
Signed-off-by: Alexander Aring <aahringo@redhat.com>
Signed-off-by: David Teigland <teigland@redhat.com>
-rw-r--r-- | fs/dlm/midcomms.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/dlm/midcomms.c b/fs/dlm/midcomms.c index 2e60d9a2c883..a3eb19c8cec5 100644 --- a/fs/dlm/midcomms.c +++ b/fs/dlm/midcomms.c @@ -1402,6 +1402,7 @@ static void midcomms_node_release(struct rcu_head *rcu) struct midcomms_node *node = container_of(rcu, struct midcomms_node, rcu); WARN_ON_ONCE(atomic_read(&node->send_queue_cnt)); + dlm_send_queue_flush(node); kfree(node); } |