diff options
| author | Miaoqian Lin <linmq006@gmail.com> | 2022-06-03 12:34:15 +0400 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2022-06-06 12:38:49 +0100 |
| commit | 7472eb8d7dd12b6b9b1a4f4527719cc9c7f5965f (patch) | |
| tree | 031037f9e715332056e375fe651b7e26a1d0a82a | |
| parent | 4f8ed19593872b710f27bbc3b7a9ce03310efc57 (diff) | |
| download | linux-stable-7472eb8d7dd12b6b9b1a4f4527719cc9c7f5965f.tar.gz linux-stable-7472eb8d7dd12b6b9b1a4f4527719cc9c7f5965f.tar.bz2 linux-stable-7472eb8d7dd12b6b9b1a4f4527719cc9c7f5965f.zip | |
ASoC: mt6797-mt6351: Fix refcount leak in mt6797_mt6351_dev_probe
of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
Fixes: f0ab0bf250da ("ASoC: add mt6797-mt6351 driver and config option")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220603083417.9011-1-linmq006@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/mediatek/mt6797/mt6797-mt6351.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/sound/soc/mediatek/mt6797/mt6797-mt6351.c b/sound/soc/mediatek/mt6797/mt6797-mt6351.c index 496f32bcfb5e..d2f6213a6bfc 100644 --- a/sound/soc/mediatek/mt6797/mt6797-mt6351.c +++ b/sound/soc/mediatek/mt6797/mt6797-mt6351.c @@ -217,7 +217,8 @@ static int mt6797_mt6351_dev_probe(struct platform_device *pdev) if (!codec_node) { dev_err(&pdev->dev, "Property 'audio-codec' missing or invalid\n"); - return -EINVAL; + ret = -EINVAL; + goto put_platform_node; } for_each_card_prelinks(card, i, dai_link) { if (dai_link->codecs->name) @@ -230,6 +231,9 @@ static int mt6797_mt6351_dev_probe(struct platform_device *pdev) dev_err(&pdev->dev, "%s snd_soc_register_card fail %d\n", __func__, ret); + of_node_put(codec_node); +put_platform_node: + of_node_put(platform_node); return ret; } |