diff options
| author | Florian Eckert <fe@dev.tdt.de> | 2023-11-27 09:16:21 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-01-20 11:51:48 +0100 |
| commit | 7db7504a3e4134b403dbc94fba807529b64ae55a (patch) | |
| tree | 47f2fc3d1e02ba2afec9c9ab5ce3e91d0a36e2c8 | |
| parent | 12786872b26a81fadd3895368d9289a2c7bd9129 (diff) | |
| download | linux-stable-7db7504a3e4134b403dbc94fba807529b64ae55a.tar.gz linux-stable-7db7504a3e4134b403dbc94fba807529b64ae55a.tar.bz2 linux-stable-7db7504a3e4134b403dbc94fba807529b64ae55a.zip | |
leds: ledtrig-tty: Free allocated ttyname buffer on deactivate
commit 25054b232681c286fca9c678854f56494d1352cc upstream.
The ttyname buffer for the ledtrig_tty_data struct is allocated in the
sysfs ttyname_store() function. This buffer must be released on trigger
deactivation. This was missing and is thus a memory leak.
While we are at it, the TTY handler in the ledtrig_tty_data struct should
also be returned in case of the trigger deactivation call.
Cc: stable@vger.kernel.org
Fixes: fd4a641ac88f ("leds: trigger: implement a tty trigger")
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20231127081621.774866-1-fe@dev.tdt.de
Signed-off-by: Lee Jones <lee@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/leds/trigger/ledtrig-tty.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/leds/trigger/ledtrig-tty.c b/drivers/leds/trigger/ledtrig-tty.c index 8ae0d2d284af..3e69a7bde928 100644 --- a/drivers/leds/trigger/ledtrig-tty.c +++ b/drivers/leds/trigger/ledtrig-tty.c @@ -168,6 +168,10 @@ static void ledtrig_tty_deactivate(struct led_classdev *led_cdev) cancel_delayed_work_sync(&trigger_data->dwork); + kfree(trigger_data->ttyname); + tty_kref_put(trigger_data->tty); + trigger_data->tty = NULL; + kfree(trigger_data); } |