diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-03-18 11:14:39 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-04-13 10:31:32 +0200 |
| commit | 8872445ae5cd3653c2f49cdb2c46536cd4895ddb (patch) | |
| tree | 775bed6d21e9f1407e16f0235d091d33fa094cf3 | |
| parent | e4149be608f464bd232f4531a770000f3c7e1f6e (diff) | |
| download | linux-stable-8872445ae5cd3653c2f49cdb2c46536cd4895ddb.tar.gz linux-stable-8872445ae5cd3653c2f49cdb2c46536cd4895ddb.tar.bz2 linux-stable-8872445ae5cd3653c2f49cdb2c46536cd4895ddb.zip | |
power: supply: axp288_charger: Fix unchecked return value
commit c3422ad5f84a66739ec6a37251ca27638c85b6be upstream.
Currently there is no check on platform_get_irq() return value
in case it fails, hence never actually reporting any errors and
causing unexpected behavior when using such value as argument
for function regmap_irq_get_virq().
Fix this by adding a proper check, a message reporting any errors
and returning *pirq*
Addresses-Coverity-ID: 1443940 ("Improper use of negative value")
Fixes: 843735b788a4 ("power: axp288_charger: axp288 charger driver")
Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Nobuhiro Iwamatsu (CIP) <nobuhiro1.iwamatsu@toshiba.co.jp>
| -rw-r--r-- | drivers/power/axp288_charger.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/power/axp288_charger.c b/drivers/power/axp288_charger.c index e4d569f57acc..0c6fed79c363 100644 --- a/drivers/power/axp288_charger.c +++ b/drivers/power/axp288_charger.c @@ -883,6 +883,10 @@ static int axp288_charger_probe(struct platform_device *pdev) /* Register charger interrupts */ for (i = 0; i < CHRG_INTR_END; i++) { pirq = platform_get_irq(info->pdev, i); + if (pirq < 0) { + dev_err(&pdev->dev, "Failed to get IRQ: %d\n", pirq); + return pirq; + } info->irq[i] = regmap_irq_get_virq(info->regmap_irqc, pirq); if (info->irq[i] < 0) { dev_warn(&info->pdev->dev, |