diff options
| author | Johan Hovold <johan@kernel.org> | 2018-05-31 16:45:52 +0200 |
|---|---|---|
| committer | Felipe Balbi <felipe.balbi@linux.intel.com> | 2018-06-18 12:41:00 +0300 |
| commit | 896e518883f18e601335908192e33426c1f599a4 (patch) | |
| tree | 0952cd38a8133342455738b47363273af1f20fda | |
| parent | 1ffba9058737af2ddeebc813faa8ea9b16bc892a (diff) | |
| download | linux-stable-896e518883f18e601335908192e33426c1f599a4.tar.gz linux-stable-896e518883f18e601335908192e33426c1f599a4.tar.bz2 linux-stable-896e518883f18e601335908192e33426c1f599a4.zip | |
usb: dwc3: of-simple: fix use-after-free on remove
The clocks have already been explicitly disabled and put as part of
remove() so the runtime suspend callback must not be run when balancing
the runtime PM usage count before returning.
Fixes: 16adc674d0d6 ("usb: dwc3: add generic OF glue layer")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
| -rw-r--r-- | drivers/usb/dwc3/dwc3-of-simple.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c index 6b3ccd542bd7..dbeff5e6ad14 100644 --- a/drivers/usb/dwc3/dwc3-of-simple.c +++ b/drivers/usb/dwc3/dwc3-of-simple.c @@ -165,8 +165,9 @@ static int dwc3_of_simple_remove(struct platform_device *pdev) reset_control_put(simple->resets); - pm_runtime_put_sync(dev); pm_runtime_disable(dev); + pm_runtime_put_noidle(dev); + pm_runtime_set_suspended(dev); return 0; } |