diff options
| author | Qiushi Wu <wu000273@umn.edu> | 2020-05-28 13:38:04 -0500 |
|---|---|---|
| committer | Sasha Levin <sashal@kernel.org> | 2020-06-29 20:08:01 -0400 |
| commit | 8da5b2305f6244184f0debde4ff3029788f27228 (patch) | |
| tree | 535cda313709fbb4e41ed8fc55d1bbb58ce97606 | |
| parent | d1633159b6c8a1fe0b7e5a635738796e2d93de6e (diff) | |
| download | linux-stable-8da5b2305f6244184f0debde4ff3029788f27228.tar.gz linux-stable-8da5b2305f6244184f0debde4ff3029788f27228.tar.bz2 linux-stable-8da5b2305f6244184f0debde4ff3029788f27228.zip | |
efi/esrt: Fix reference count leak in esre_create_sysfs_entry.
[ Upstream commit 4ddf4739be6e375116c375f0a68bf3893ffcee21 ]
kobject_init_and_add() takes reference even when it fails.
If this function returns an error, kobject_put() must be called to
properly clean up the memory associated with the object. Previous
commit "b8eb718348b8" fixed a similar problem.
Fixes: 0bb549052d33 ("efi: Add esrt support")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Link: https://lore.kernel.org/r/20200528183804.4497-1-wu000273@umn.edu
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/firmware/efi/esrt.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c index 341b8c686ec7..4aaaccf95b36 100644 --- a/drivers/firmware/efi/esrt.c +++ b/drivers/firmware/efi/esrt.c @@ -182,7 +182,7 @@ static int esre_create_sysfs_entry(void *esre, int entry_num) rc = kobject_init_and_add(&entry->kobj, &esre1_ktype, NULL, "%s", name); if (rc) { - kfree(entry); + kobject_put(&entry->kobj); return rc; } } |