summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStefan Wahren <wahrenst@gmx.net>2024-01-28 21:10:54 +0100
committerDavid S. Miller <davem@davemloft.net>2024-01-31 13:38:50 +0000
commit8f3655d8a515bdef18eeccf4245e3e3c458d7fd3 (patch)
tree46fbbd6e4a69d88e93326e2db417045ba3d6a681
parent0a8ef9ed7a16d42fe1c3bf4656312d875a7e1ce5 (diff)
downloadlinux-stable-8f3655d8a515bdef18eeccf4245e3e3c458d7fd3.tar.gz
linux-stable-8f3655d8a515bdef18eeccf4245e3e3c458d7fd3.tar.bz2
linux-stable-8f3655d8a515bdef18eeccf4245e3e3c458d7fd3.zip
qca_spi: Log expected signature in error case
Most of the users doesn't know the expected signature of the QCA700x. So provide it within the error message. Btw use lowercase for hex as in the rest of the driver. Signed-off-by: Stefan Wahren <wahrenst@gmx.net> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ethernet/qualcomm/qca_spi.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c
index b35fabcd488b..d2d68c20b32c 100644
--- a/drivers/net/ethernet/qualcomm/qca_spi.c
+++ b/drivers/net/ethernet/qualcomm/qca_spi.c
@@ -1006,8 +1006,8 @@ qca_spi_probe(struct spi_device *spi)
qcaspi_read_register(qca, SPI_REG_SIGNATURE, &signature);
if (signature != QCASPI_GOOD_SIGNATURE) {
- dev_err(&spi->dev, "Invalid signature (0x%04X)\n",
- signature);
+ dev_err(&spi->dev, "Invalid signature (expected 0x%04x, read 0x%04x)\n",
+ QCASPI_GOOD_SIGNATURE, signature);
free_netdev(qcaspi_devs);
return -EFAULT;
}