diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2022-03-04 16:15:34 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2022-03-07 13:14:49 +0000 |
| commit | 9a33f5632ca573e512c49fa46cc7131cbc83d4c9 (patch) | |
| tree | eea139214b0587ad8b06b5a8eddffff5b33d7002 | |
| parent | 00925272f166db31fed73f3c00c151eb5f7ce1d8 (diff) | |
| download | linux-stable-9a33f5632ca573e512c49fa46cc7131cbc83d4c9.tar.gz linux-stable-9a33f5632ca573e512c49fa46cc7131cbc83d4c9.tar.bz2 linux-stable-9a33f5632ca573e512c49fa46cc7131cbc83d4c9.zip | |
ASoC: amd: pcm-dma: Fix signedness bug in acp3x_audio_probe()
The "adata->i2s_irq" variable is unsigned so this error handling
code will not work.
Fixes: 87d71a128771 ("ASoC: amd: pcm-dma: Use platform_get_irq() to get the interrupt")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20220304131534.GD28739@kili
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/amd/raven/acp3x-pcm-dma.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/sound/soc/amd/raven/acp3x-pcm-dma.c b/sound/soc/amd/raven/acp3x-pcm-dma.c index e4f8dbf0d11d..6aec11cf0a6a 100644 --- a/sound/soc/amd/raven/acp3x-pcm-dma.c +++ b/sound/soc/amd/raven/acp3x-pcm-dma.c @@ -394,9 +394,10 @@ static int acp3x_audio_probe(struct platform_device *pdev) if (!adata->acp3x_base) return -ENOMEM; - adata->i2s_irq = platform_get_irq(pdev, 0); - if (adata->i2s_irq < 0) - return -ENODEV; + status = platform_get_irq(pdev, 0); + if (status < 0) + return status; + adata->i2s_irq = status; dev_set_drvdata(&pdev->dev, adata); status = devm_snd_soc_register_component(&pdev->dev, |