diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2023-04-21 13:44:04 +0300 |
|---|---|---|
| committer | Kalle Valo <kvalo@kernel.org> | 2023-05-05 15:01:37 +0300 |
| commit | 9d4f491b860ea6d04471c3342093b86a46eee63e (patch) | |
| tree | b8eae9a9594347364c6a91bca0142a3d9a6fbd13 | |
| parent | a83c6bb22745168dbe6592a9872f262615ee174b (diff) | |
| download | linux-stable-9d4f491b860ea6d04471c3342093b86a46eee63e.tar.gz linux-stable-9d4f491b860ea6d04471c3342093b86a46eee63e.tar.bz2 linux-stable-9d4f491b860ea6d04471c3342093b86a46eee63e.zip | |
wifi: rtw89: fix rtw89_read_chip_ver() for RTL8852B and RTL8851B
The if statement is reversed so it will not record the chip version.
This was detected using Smatch:
drivers/net/wireless/realtek/rtw89/core.c:3593 rtw89_read_chip_ver()
error: uninitialized symbol 'val'.
Fixes: a6fb2bb84654 ("wifi: rtw89: read version of analog hardware")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/e4d912a2-37f8-4068-8861-7b9494ae731b@kili.mountain
| -rw-r--r-- | drivers/net/wireless/realtek/rtw89/core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/realtek/rtw89/core.c b/drivers/net/wireless/realtek/rtw89/core.c index c376dae916e7..630124f9e025 100644 --- a/drivers/net/wireless/realtek/rtw89/core.c +++ b/drivers/net/wireless/realtek/rtw89/core.c @@ -3668,7 +3668,7 @@ static void rtw89_read_chip_ver(struct rtw89_dev *rtwdev) if (chip->chip_id == RTL8852B || chip->chip_id == RTL8851B) { ret = rtw89_mac_read_xtal_si(rtwdev, XTAL_SI_CV, &val); - if (!ret) + if (ret) return; rtwdev->hal.acv = u8_get_bits(val, XTAL_SI_ACV_MASK); |